feat: check if Pat-ID is reasonable value #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes simple refac by returning early if match has been found
pcvolkmer
changed the title
chgl
requested changes
Aug 30, 2024
src/main/java/org/miracum/streams/ume/obdstofhir/mapper/ObdsToFhirMapper.java
Show resolved
Hide resolved
src/main/java/org/miracum/streams/ume/obdstofhir/mapper/ObdsToFhirMapper.java
Outdated
Show resolved
Hide resolved
src/test/java/org/miracum/streams/ume/obdstofhir/mapper/ObdsToFhirIntegrationTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/miracum/streams/ume/obdstofhir/mapper/ObdsToFhirMapperTests.java
Outdated
Show resolved
Hide resolved
src/test/java/org/miracum/streams/ume/obdstofhir/mapper/ObdsToFhirMapperTests.java
Outdated
Show resolved
Hide resolved
src/test/java/org/miracum/streams/ume/obdstofhir/mapper/ObdsToFhirMapperTests.java
Outdated
Show resolved
Hide resolved
src/main/java/org/miracum/streams/ume/obdstofhir/mapper/ObdsToFhirMapper.java
Outdated
Show resolved
Hide resolved
This updates the logging message shown if the input does not match the pattern. Co-authored-by: chgl <[email protected]>
This also re enables this config option with a default value. Co-authored-by: chgl <[email protected]>
Co-authored-by: chgl <[email protected]>
Co-authored-by: chgl <[email protected]>
chgl
approved these changes
Aug 30, 2024
miracum-bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
## [2.2.0](v2.1.3...v2.2.0) (2024-09-04) ### Features * support capture groups in Pat-ID convert ([#92](#92)) ([91edc17](91edc17)) ### Bug Fixes * check if Pat-ID is reasonable value ([#90](#90)) ([812d57c](812d57c)) * check if value matches ICD10GM pattern ([#98](#98)) ([99d60ad](99d60ad)) * date conversion for oBDS 3.x ([#78](#78)) ([32cd649](32cd649)) * **deps:** update all non-major dependencies ([3934356](3934356)) * return timespan of all partial radiations ([#80](#80)) ([c73a4fd](c73a4fd)), closes [#79](#79) ### CI/CD * updated build workflow to create signed releases ([#82](#82)) ([346d157](346d157)) ### Miscellaneous Chores * **config:** dont release on refactor and only on deps chore ([#68](#68)) ([76e18ec](76e18ec)) * **deps:** update github-actions ([#81](#81)) ([b89f7fd](b89f7fd)) ### Documentation * added CONTRIBUTING and DEVELOPMENT md ([#100](#100)) ([ed52cef](ed52cef)) * added SECURITY.md ([343c5e3](343c5e3))
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.