forked from treastrain/TRETJapanNFCReader
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS NFCReader切り出し対応(APDUコマンド切り出し) #1
Open
mizuno-bks
wants to merge
10
commits into
master
Choose a base branch
from
ios/fix/lib
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sheile
reviewed
Sep 8, 2023
Sheile
reviewed
Sep 8, 2023
Sheile
reviewed
Sep 9, 2023
Sheile
reviewed
Sep 9, 2023
Sheile
reviewed
Sep 9, 2023
Sheile
reviewed
Sep 9, 2023
Sources/MIFARE/IndividualNumber/IndividualNumberReaderExtension.swift
Outdated
Show resolved
Hide resolved
Sheile
reviewed
Sep 9, 2023
Sources/MIFARE/IndividualNumber/IndividualNumberReaderReadFunctionsExtensions.swift
Outdated
Show resolved
Hide resolved
Sheile
reviewed
Sep 9, 2023
Sources/MIFARE/IndividualNumber/IndividualNumberReaderReadFunctionsExtensions.swift
Outdated
Show resolved
Hide resolved
@mizuno-bks また、コミットメッセージもコミットと合っていないように見えます。 |
Sheile
reviewed
Sep 9, 2023
Sources/MIFARE/IndividualNumber/IndividualNumberReaderExtension.swift
Outdated
Show resolved
Hide resolved
Sheile
reviewed
Sep 9, 2023
Sources/MIFARE/IndividualNumber/IndividualNumberReaderExtension.swift
Outdated
Show resolved
Hide resolved
Sheile
reviewed
Sep 9, 2023
Sources/MIFARE/IndividualNumber/IndividualNumberReaderExtension.swift
Outdated
Show resolved
Hide resolved
Sheile
reviewed
Sep 9, 2023
Sources/MIFARE/IndividualNumber/IndividualNumberReaderExtension.swift
Outdated
Show resolved
Hide resolved
Sheile
reviewed
Sep 9, 2023
Sources/MIFARE/IndividualNumber/IndividualNumberReaderExtension.swift
Outdated
Show resolved
Hide resolved
Sheile
reviewed
Sep 9, 2023
Sources/MIFARE/IndividualNumber/IndividualNumberReaderExtension.swift
Outdated
Show resolved
Hide resolved
Sheile
reviewed
Sep 9, 2023
Sources/MIFARE/IndividualNumber/IndividualNumberReaderExtension.swift
Outdated
Show resolved
Hide resolved
Sheile
reviewed
Sep 9, 2023
Sources/MIFARE/IndividualNumber/IndividualNumberReaderExtension.swift
Outdated
Show resolved
Hide resolved
Sheile
reviewed
Sep 9, 2023
Sources/MIFARE/IndividualNumber/IndividualNumberReaderExtension.swift
Outdated
Show resolved
Hide resolved
Sheile
reviewed
Sep 9, 2023
Sources/MIFARE/IndividualNumber/IndividualNumberReaderExtension.swift
Outdated
Show resolved
Hide resolved
Sheile
reviewed
Sep 9, 2023
Sources/MIFARE/IndividualNumber/IndividualNumberReaderReadFunctionsExtensions.swift
Outdated
Show resolved
Hide resolved
Sheile
reviewed
Sep 9, 2023
Sources/MIFARE/IndividualNumber/IndividualNumberReaderReadFunctionsExtensions.swift
Outdated
Show resolved
Hide resolved
Sheile
reviewed
Sep 9, 2023
Sources/MIFARE/IndividualNumber/IndividualNumberReaderReadFunctionsExtensions.swift
Outdated
Show resolved
Hide resolved
Sheile
reviewed
Sep 9, 2023
Sources/MIFARE/IndividualNumber/IndividualNumberReaderReadFunctionsExtensions.swift
Outdated
Show resolved
Hide resolved
mizuno-bks
force-pushed
the
ios/fix/lib
branch
from
September 13, 2023 04:58
38b1b5b
to
c2a9767
Compare
mizuno-bks
force-pushed
the
ios/fix/lib
branch
from
September 14, 2023 09:36
c2a9767
to
1bb5f0b
Compare
Sheile
reviewed
Sep 15, 2023
Sheile
reviewed
Sep 15, 2023
Sheile
reviewed
Sep 15, 2023
Sheile
reviewed
Sep 15, 2023
Sheile
reviewed
Sep 15, 2023
Sheile
reviewed
Sep 15, 2023
Sheile
reviewed
Sep 15, 2023
Sheile
reviewed
Sep 15, 2023
Sources/MIFARE/IndividualNumber/IndividualNumberReaderReadFunctions.swift
Outdated
Show resolved
Hide resolved
Sheile
reviewed
Sep 15, 2023
Sources/MIFARE/IndividualNumber/IndividualNumberReaderReadFunctions.swift
Outdated
Show resolved
Hide resolved
Sheile
reviewed
Sep 15, 2023
Sources/MIFARE/IndividualNumber/IndividualNumberReaderReadFunctions.swift
Outdated
Show resolved
Hide resolved
This was referenced Sep 25, 2023
Open
残課題についてはIssueに記載して別途対応としています。 |
Sheile
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
・マインバーカードの電子証明書読み取り処理の追加
・APDUコマンドでInfo.plistの値を使用するように修正