fix output_value not referencing correct key #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes (at least partially) #23 |
pmoranga
reviewed
Oct 17, 2017
| $label =~ s/[^a-zA-Z0-9_-]//g; | ||
| my $output_value; | ||
| $output_value = $json_response->{$key}; | ||
| $output_value = $json_response->{$label}; |
There was a problem hiding this comment.
Wont this return $label just when it exists on the root of the json ??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the output_value var referencing, which would produce an error like
The output_value var was attempting to reference a key like:
$json_response->{$key}where
$key = "{foo}"However, that would interpolate as:
$json_repsonse->{"{foo}"}which obviously doesn't work.