diff --git a/ruff.toml b/ruff.toml index 0dce444f..25125cd7 100644 --- a/ruff.toml +++ b/ruff.toml @@ -68,7 +68,6 @@ ignore = [ "COM812", # ignore due to conflict with formatter "ISC001", # ignore due to conflict with formatter "E501", # managed by formatter - "SLF001", # allow accessing private members "TD002", # don't require author of TODO "TD003", # don't require link to TODO "D100", # don't enforce existance of docstrings diff --git a/timed/conftest.py b/timed/conftest.py index 10d24962..526996a0 100644 --- a/timed/conftest.py +++ b/timed/conftest.py @@ -15,7 +15,7 @@ def register_module(module): for _name, obj in inspect.getmembers(module): - if isinstance(obj, FactoryMetaClass) and not obj._meta.abstract: + if isinstance(obj, FactoryMetaClass) and not obj._meta.abstract: # noqa: SLF001 register(obj) diff --git a/timed/mixins.py b/timed/mixins.py index a36d30c0..3ee36a4a 100644 --- a/timed/mixins.py +++ b/timed/mixins.py @@ -50,7 +50,7 @@ def get_serializer(self, data=None, *args, **kwargs): # prefetch data for all related fields prefetch_per_field = {} serializer_class = self.get_serializer_class() - for key, value in serializer_class._declared_fields.items(): + for key, value in serializer_class._declared_fields.items(): # noqa: SLF001 if self._is_related_field(value): source = value.source or key if many: diff --git a/timed/reports/filters.py b/timed/reports/filters.py index 5afa6f7d..52726275 100644 --- a/timed/reports/filters.py +++ b/timed/reports/filters.py @@ -78,9 +78,9 @@ def filter_queryset(self, queryset): duration_ref = self._refs["reports_ref"] + "__duration" - full_qs = qs._base.annotate( + full_qs = qs._base.annotate( # noqa: SLF001 duration=Coalesce( - Sum(duration_ref, filter=qs._agg_filters), + Sum(duration_ref, filter=qs._agg_filters), # noqa: SLF001 Value("00:00:00", DurationField(null=False)), ), pk=F("id"), diff --git a/timed/reports/tests/test_work_report.py b/timed/reports/tests/test_work_report.py index b5773086..f1d683eb 100644 --- a/timed/reports/tests/test_work_report.py +++ b/timed/reports/tests/test_work_report.py @@ -153,7 +153,7 @@ def test_generate_work_report_name(customer_name, project_name, expected): # slashes should be dropped from file name project = ProjectFactory.create(customer=customer, name=project_name) - name = view._generate_workreport_name(test_date, test_date, project) + name = view._generate_workreport_name(test_date, test_date, project) # noqa: SLF001 assert name == expected diff --git a/timed/reports/views.py b/timed/reports/views.py index 877876fc..582d25df 100644 --- a/timed/reports/views.py +++ b/timed/reports/views.py @@ -113,7 +113,7 @@ def filter_base(self, *args, **kwargs): def _clone(self): return StatisticQueryset( model=self.model, - base_qs=self._base._clone(), + base_qs=self._base._clone(), # noqa: SLF001 catch_prefixes=self._catch_prefixes, agg_filters=self._agg_filters, )