Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add content to site #69

Draft
wants to merge 20 commits into
base: feat/add-docusaurus
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
e20981b
fix: invalid email in pre commit workflow (#66)
jonathan-mayer Oct 24, 2024
7371c33
Merge branch 'main' into feat/add-content-to-site
jonathan-mayer Oct 25, 2024
f5f10da
feat: add how to run the website in readme
jonathan-mayer Oct 25, 2024
54ce506
docs: changed code comments to match convention
jonathan-mayer Nov 4, 2024
4a0f7cf
feat: update pre commit config to match new files
jonathan-mayer Nov 4, 2024
fc4e17c
docs: fix spelling mistakes in docs
jonathan-mayer Nov 4, 2024
3cbd3e2
docs: update readme to refer to the website
jonathan-mayer Nov 4, 2024
da0fca8
fix: update pre commit to not fail because of markdown headings
jonathan-mayer Nov 4, 2024
10a9b8b
fix: made regexList match whole string
jonathan-mayer Nov 4, 2024
9d3634f
feat: a lot
jonathan-mayer Nov 19, 2024
0ee5140
feat: add mdx highlighing
jonathan-mayer Nov 22, 2024
1575bfd
docs: fix indefinite article misuse
jonathan-mayer Nov 24, 2024
443482d
docs: add workflow documentation
jonathan-mayer Nov 24, 2024
82272e8
feat: update pre commit config to better match relevent files
jonathan-mayer Nov 24, 2024
2617e9e
docs: added docs for adding/changing pages and categories
jonathan-mayer Nov 24, 2024
00b4aad
fix: prevent todo comments hook
jonathan-mayer Nov 24, 2024
d032665
feat: added yaml, json, js, ts, jsx, tsx to file extensions checked b…
jonathan-mayer Nov 24, 2024
d585c38
feat: markdown links
jonathan-mayer Nov 25, 2024
6fc3686
feat: add best practices for developing website
jonathan-mayer Dec 3, 2024
eaf8c04
docs: add documentation for user level configuration layers
jonathan-mayer Dec 9, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/pre_commit.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ jobs:
SKIP: "no-commit-to-branch" # if not skipped, will always fail on main
- name: Push changes
run: |
git config --global user.name "github-actions"
git config --global user.email "github-actions@github.com"
git config --global user.name "github-actions[bot]"
git config --global user.email "github-actions[bot]@users.noreply.github.com"
git add .
if git diff-index --quiet HEAD; then
echo "No changes were made"
Expand Down
22 changes: 6 additions & 16 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
fail_fast: true
repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v2.3.0
rev: v5.0.0
hooks:
- id: end-of-file-fixer
- id: trailing-whitespace
Expand All @@ -22,26 +22,16 @@ repos:
rev: v3.0.1
hooks:
- id: prettier
files: \.md$
files: \.(md|mdx)$
- repo: local
hooks:
- id: prevent-todo-comments
name: prevent todo comments
entry: '\/\/ *(TODO|FIXME)\b' # matches a golang comment beginning with "TODO" or "FIXME"
entry: '( |^)(//|#|<!--|/\*)\s*(TODO|FIXME)\b' # matches a comment beginning with "TODO" or "FIXME"
language: pygrep
files: \.go$
files: \.(go|md|mdx|yaml|json|js|ts|jsx|tsx)$
- id: prevent-too-small-headings
name: prevent too small headings
entry: "^#{5,} " # matches a h5 or smaller markdown heading
entry: "^#{5,} " # matches an h5 or smaller markdown heading
language: pygrep
files: \.md$
- id: prevent-overly-nested-hierarchy
name: prevent overly nested hierarchy
entry: "^( ){2,}- " # matches a markdown list with 2 or more indentations
language: pygrep
files: \.md$
- id: prevent-invalid-alert-types
name: prevent invalid alert types
entry: '(?i)^> \[!(?!\b(?:NOTE|TIP|IMPORTANT|WARNING|CAUTION)\b).+\]' # matches a github markdown callout/alert that doesn't use one of the supported keywords
language: pygrep
files: \.md$
files: \.(md|mdx)$
20 changes: 12 additions & 8 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,27 +36,31 @@ Commits:

Try to stick to golang best practices and standards:

<!-- keep this list updated everytime someone opens a pr with best practice issues -->
<!-- keep this list updated every time someone opens a pr with best practice issues -->

- Package structure standards: https://github.com/golang-standards/project-layout
- [Package structure standards](https://github.com/golang-standards/project-layout)
- Use guard clauses if applicable
- Try to avoid using else. Most of the time these can be replaced by just placing the else block content directly after the if or by refactoring the if block to be an additional function.
- Comments on funcs/types (esp. public ones)
- Only make functions public if necessary

## Issues

If applicable use the issue template. This ensures a consistent structure which makes it easier to find important details.
Issues which aren't ready for processing, can be marked as a draft by writing "Draft: " infront of the issue name.
If applicable use the issue template.
This ensures a consistent structure which makes it easier to find important details.
Issues which aren't ready for processing, can be marked as a draft by writing "Draft: " in front of the issue name.

## Pull Requests

Use the Pull Request Template. This ensures a consistent structure which makes it easier to find important details.
Use the Pull Request Template.
This ensures a consistent structure which makes it easier to find important details.
Set yourself and any other collaborators as assignee.

## Pre Commit

It is recommended to install pre-commit. This insures that formatting is consistent, you don't commit to protected branches and you don't accidentally commit broken code or new functionality without changing the tests. The installation process is in the [README](README.md#setting-up-pre-commit)
It is recommended to install pre-commit.
This ensures that formatting is consistent, you don't commit to protected branches and you don't accidentally commit broken code or new functionality without changing the tests.
The installation process is on [our website](https://caas-team.github.io/GoKubeDownscaler/guides/developing#setting-up-pre-commit).

## Versioning

Expand All @@ -67,7 +71,7 @@ Releases are following the semver versioning standard:
Layout: `<Major>.<Minor>.<Patch>` (example: 1.1.0)

- MAJOR: increment on breaking changes
- MINOR: increment on new funcitonality/features
- MINOR: increment on new functionality/features
- PATCH: increment on small bug fixes

You can find more infomration on semantic versioning here [here](https://semver.org/)
You can find more information on semantic versioning [on the official website](https://semver.org/).
Loading
Loading