Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: Make sidebar accessible by default #930

Open
TobyKLight opened this issue Nov 27, 2024 · 3 comments
Open

Accessibility: Make sidebar accessible by default #930

TobyKLight opened this issue Nov 27, 2024 · 3 comments
Assignees

Comments

@TobyKLight
Copy link
Contributor

TobyKLight commented Nov 27, 2024

Request is to make the sidebar accessible to keyboard users and assistive technology like screen readers.

The advantage of doing this from cables.gl side is that every single patch using sidebar already has a massive increase in accessibility.

I think that would include

  • Every interactive widget can be selected with TAB
  • Ensure Widgets respond to standard keyboard shortcuts.
  • Widgets are semantically correct in the DOM (E.g. buttons are either <button> tag or have role="button")
  • The interactive part of each widget has aria-labelledby attribute set to the ID of the element that captions it.
    • This means screen reader users that TAB to an input field also hear what the label of that field is.
  • The whole widget panel has an appropriate role (eg role="dialog") and then an aria-labelledby attribute that points to the title element.
    • This should mean that when a screen reader user moves their focus initially into the panel that it's announced as 'Patch visualisation dialog" and then the widget label.
@TobyKLight TobyKLight added the new label Nov 27, 2024
@pandrr
Copy link
Member

pandrr commented Nov 28, 2024

Screen.Recording.2024-11-28.at.09.56.17.mov

this looks quite good now...
also outline is only set using focus-visible, so will not show when just clicking on it

@TobyKLight
Copy link
Contributor Author

that's a great start

In terms of the roles and aria-labelledby attribute here is a video demonstrating what I'm talking about with the screen reader.

https://youtu.be/OzgLJhdJ-04

@steam0r steam0r removed the new label Dec 2, 2024
@pandrr
Copy link
Member

pandrr commented Dec 4, 2024

sidebar slider, button and toggle now have aria label. toggle can now be accessed with tab and enter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants