Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow configuring hosted_zone_id #51

Merged
merged 1 commit into from
Aug 2, 2024
Merged

feat: allow configuring hosted_zone_id #51

merged 1 commit into from
Aug 2, 2024

Conversation

andrew-d
Copy link
Contributor

@andrew-d andrew-d commented Aug 1, 2024

As requested in libdns/route53#261

@andrew-d
Copy link
Contributor Author

andrew-d commented Aug 1, 2024

@aymanbagabas Here's the PR you requested. I pushed the go.mod update as a second commit since https://github.com/libdns/route53 doesn't have a release that contains the commit. Happy to wait to update to a tagged release, or use this, as you prefer.

@andrew-d andrew-d marked this pull request as ready for review August 1, 2024 02:23
@aymanbagabas
Copy link
Collaborator

@andrew-d Thank you for the PR. I've released libdns/[email protected]

@andrew-d andrew-d force-pushed the andrew/hosted-zone-id branch from b127cab to 5784737 Compare August 1, 2024 21:05
@andrew-d
Copy link
Contributor Author

andrew-d commented Aug 1, 2024

@aymanbagabas updated and squashed!

@aymanbagabas aymanbagabas merged commit 5e0037b into caddy-dns:master Aug 2, 2024
2 checks passed
@andrew-d andrew-d deleted the andrew/hosted-zone-id branch September 1, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aymanbagabas aymanbagabas aymanbagabas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrew-d @aymanbagabas