Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FYI: cache tests #54

Open
mnot opened this issue Jul 13, 2023 · 3 comments
Open

FYI: cache tests #54

mnot opened this issue Jul 13, 2023 · 3 comments

Comments

@mnot
Copy link

mnot commented Jul 13, 2023

Just so you know, I've added caddy + cache-handler to https://cache-tests.fyi

Happy to talk through individual tests if there's interest.

@darkweak
Copy link
Collaborator

Hey @mnot, thank you for adding Caddy there. I wonder if the default HTTP cache behavior (without any extra configuration) should not store the response if this one doesn't have the Cache-Control HTTP response header.
We will work on the main codebase to support most of the cache-tests test suite.

@mholt
Copy link
Member

mholt commented Jul 13, 2023

Thank you Mark! And thanks @darkweak for maintaining this 😊

@Jimbolino
Copy link

Thnx, this was really helpful, because i couldn't figure out why my http 400 responses were not cached, even though they contain the right cache headers. Changing them to 404 fixed the issue for me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants