Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AllowTrafficZone incorrect type hint in constructor #35

Open
zazyzaya opened this issue Apr 20, 2024 · 1 comment
Open

AllowTrafficZone incorrect type hint in constructor #35

zazyzaya opened this issue Apr 20, 2024 · 1 comment
Assignees

Comments

@zazyzaya
Copy link

zazyzaya commented Apr 20, 2024

Tiny issue, but the constructor for AllowTrafficZone is written as

def __init__(self, session: int, agent: str, from_subnet: str, to_subnet: IPv4Network):

when it should be

def __init__(self, session: int, agent: str, from_subnet: str, to_subnet: str):

and it's making my IDE sad.

@MitchellKiely MitchellKiely self-assigned this Apr 24, 2024
@MitchellKiely
Copy link
Collaborator

Hi @zazyzaya,
Apologies for making your IDE sad. The error has been noted, and will be changed after the challenge concludes on May the 10th. We don't want to push any changes, however little, as it means all submissions will have to be reevaluated. We'll make sure to modify this after the challenge is finished.
Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants