-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate revised Benefits application copy to Spanish #1410
Comments
I was going through the The text that appears in the tab is called, on Sometimes the |
Ugh. We do have all of that copy in a google doc somewhere. I don't think it needs updating (as we haven't changed layouts), but it definitely needs to be accounted for in the new Google Sheets. I'lll take a look right now. Edit: Okay I found these documents which all include a "Page Title" which would be the .django title. @indexing I think we should review these at our copy session and adjust page titles if needed |
When prepping the CSV file for our translation vendor, I noted that page title are not yet part of master copy sheet. I referenced the current app for many existing titles, but added ones for pages that don't exist yet (such as veterans.) I did a review of the titles together and here's my proposal for a complete list. (I matched the titles to the correct pages in the spreadsheet, but thought it useful to present all title here as a complete set.) Choose transit agency | Cal-ITP Benefits A couple notes:
@machikoyasuda I will submit the titles for translation After translation, we will need to review the tag of each page and update accordingly. Perhaps it makes sense to capture this effort is a distinct issue? I'll let you make that call. |
Yesterday I prepared the CSV file that iBabble-on requires for translation. Unfortunately, they need the string data structured differently than the layout we use to sync data from the master sheet to Figma, so I had to do a good deal of work to prepare the CSV file. Here's a summary of changes.
@srhhnry You will need to specify the URL above when syncing to Figma, but everything should work as it did with the initial file. Let's delete Benefits Copy Master Google Sheet to avoid confusion. Lastly, here is the CSV file I gave to iBabble-on: Cal-ITP Benefits Application Copy (Configurable Strings) - forTranslation.csv |
@indexing Thanks for these detailed notes and all the Google Spreadsheet-wrangling. This is going to improve our process so much. I had one small suggestion for the Google Spreadsheet. I'd like to have a clear record of exactly which version from which day was sent to iBabble-on, and what's been deployed, etc., so we can use the Google Spreadsheet version history tool like GitHub history. You can name a version like this: The name could be something like |
I synced the new Google Sheet to the Benefits configurable string Figma board and it looks like nothing broke and we are good to go there. Just a heads up that I don't believe I can currently sync different tabs within the same Google sheet. There's a somewhat complicated workaround (unofficial) that I tried and could get to work, but maybe someone else can help me figure that out in the future. |
@vykster The invoice is ready in iBabble-on. We simply need to pay before they will begin work on translations. |
done
…On Mon, Jul 3, 2023 at 3:09 PM Andy Walker ***@***.***> wrote:
@vykster <https://github.com/vykster> The invoice is ready in iBabble-on.
We simply need to pay before they will begin work on translations.
cc// @machikoyasuda <https://github.com/machikoyasuda>
https://www.ibabbleon.com/invoice/show.php?no=nta1ote3
—
Reply to this email directly, view it on GitHub
<#1410 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAWB5W4VCUG6LVTRSAXE3TXOM7KXANCNFSM6AAAAAAYVZELKQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Update as of Monday, July 10th: Translations are done and the file is posted in Slack. @indexing can update the Google Spreadsheet when he is back. |
After going through this full translation process for this PR #1572 #1629, I have a few feedback notes: Copy missing from spreadsheet and Figma
Copy missing from spreadsheet
Some capitalization/formatting is different from FigmaSee @angela-tran's comment: #1629 (comment) |
@machikoyasuda I'm adding the missing strings you note to the spreadsheet. This is the logout confirmation view (="LoggedOut"). I added the alt text, but the confirmation string is different in the spreadsheet, "You have successfully logged out. Thank you for using Cal-ITP Benefits!" rather than "Logged out." Do I have the correct view? Is there a different one? Secondly, I'm wondering if we should remove the alt text string altogether here for the icon. Other error pages with a different icon don't have alt text (according to the spreadsheet). See Eligibility Error as an example. @srhhnry Can we consider the icon supplemental and, therefore, drop the alt text string? Or is there is rationale for having the alt text here but not elsewhere?
Added alt text to these views in spreadsheet:
|
Maybe not on the spreadsheet, but all those icon have alt text in the app. For the error icon alt text, we have: Here are the other icon alt texts in the app:
|
@indexing The page is correct. The |
Yup, definitely a legacy issue and worth clarifying.
On Mon, Aug 14, 2023 at 6:05 PM Kegan Maher ***@***.***> wrote:
@srhhnry <https://github.com/srhhnry> I think this goes back to our
recent redefinition of which images needs alt text; the icons have all had
it since day 1 of the app.
But we'll drop that in #1651
<#1651>
—
Reply to this email directly, view it on GitHub
<#1410 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJE6HDQNBNVD3Z72H4HGG3XVKOK7ANCNFSM6AAAAAAYVZELKQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
[image: logo] <http://calitp.org/>Sarah Henry
UX Designer, California Integrated Mobility
California Department of Transportation
*calitp.org <http://calitp.org/> | 954.937.8894 *Visit
CAMobilityMarketplace.org <http://camobilitymarketplace.org/> for a catalog
of code-compliant products and services for Transit Providers.
Subscribe to our
<http://www.placeandpage.la/cal-itp_emlsig/cal-itp_sigblock_2.html>Mobility
Newsletter
<https://lp.constantcontactpages.com/su/eLbtFoE/calitp?source_id=a41b99cd-7f28-4be8-a286-f9e75fc7bbce&source_type=em&c=>
for the latest Cal-ITP and Caltrans updates.
|
@machikoyasuda Ah. Got it. I have title of that page in the spreadsheet as Logout confirmation | Cal-ITP Benefits. I prefer the phrasing in the spreadsheet, but not a hill I'm prepared to die on. :) |
@indexing I believe this Issue is complete, so can it be closed? |
@machikoyasuda @thekaveman I've updated the spreadsheet with the missing copy.
|
We recently revised English copy throughout the application, added benefits eligibility for veterans, and made accessibility improvements by adding alt text in English to various elements in the Benefits application (see #1392 #1137).
All of this text is application content that may need to be understood by Spanish speakers, so we need to translate all instances in English to Spanish.
User stories
As a Spanish speaker verifying my eligibility for benefits, I need to understand all copy in the application, so I can successfully navigate the eligibility workflow.
As a Spanish speaker using a screen reader to verify my eligibility for benefits, I need to understand the description of all elements in the application in my language, so I can successfully navigate the eligibility workflow.
Acceptance criteria
There is alt text in English for all of the following elements in the application:
And...
And...
Definition of "Done"
When a user switches their language preference to Spanish in the Benefits application, the text and alt text for all elements listed above displays in Spanish.
The output of web accessibility testing utility confirms the above.
Relevant resources
The text was updated successfully, but these errors were encountered: