Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Press releases #261

Merged
merged 4 commits into from
Oct 23, 2023
Merged

Refactor: Press releases #261

merged 4 commits into from
Oct 23, 2023

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Oct 3, 2023

closes #234

  • Converts 3 press releases from PDF to HTML format
  • Corrects links of PDF-version press releases with new HTML-version press release links
  • Old PDF links still available

Compare new press releases vs. old

  1. https://deploy-preview-261--cal-itp-website.netlify.app/press/cal-itp-dgs-rfp-msa vs. https://deploy-preview-261--cal-itp-website.netlify.app/assets/Contactless.Payments.MSA.pdf
  2. https://deploy-preview-261--cal-itp-website.netlify.app/press/valleycan-preloaded-reloadable-ev-charging vs. https://valleycan.org/wp-content/uploads/2022/08/ValleyCAN_PR_080122_Final.pdf
  3. https://deploy-preview-261--cal-itp-website.netlify.app/press/cal-itp-first-net-cellular-plans vs. https://deploy-preview-261--cal-itp-website.netlify.app/assets/Cal-ITP.FirstNet.PressRelease.221103.pdf

Notes

  • The links in these press releases are regular links, formatted in Markdown. They do NOT have target="_blank" in them. It would be a lot of manual work to convert all of them, and that's not something we've done on prior HTML press releases. Users can click their web browser Back button to go back, or use keyboard shortcuts, etc.
  • In the case where a web-headline was written for a PDF headline, the web-headline was used.
  • Headlines were changed to sentence-case.

Testing social media link preview

image image

@machikoyasuda machikoyasuda requested a review from a team as a code owner October 3, 2023 00:07
@machikoyasuda machikoyasuda self-assigned this Oct 3, 2023
@netlify
Copy link

netlify bot commented Oct 3, 2023

Deploy Preview for cal-itp-website ready!

Name Link
🔨 Latest commit 53aa702
🔍 Latest deploy log https://app.netlify.com/sites/cal-itp-website/deploys/651b5b3b9633f300086a91a3
😎 Deploy Preview https://deploy-preview-261--cal-itp-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@machikoyasuda machikoyasuda added this to the Calitp.org redesign milestone Oct 3, 2023
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes all look great 👍

@machikoyasuda machikoyasuda merged commit 8e28c80 into main Oct 23, 2023
3 checks passed
@machikoyasuda machikoyasuda deleted the refactor/press-releases-html branch October 23, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor all Cal-ITP Press Release PDFs to use Press Release template
2 participants