Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Azure firewall to allow requests to static files #337

Closed
angela-tran opened this issue Sep 29, 2023 · 3 comments · Fixed by #338
Closed

Configure Azure firewall to allow requests to static files #337

angela-tran opened this issue Sep 29, 2023 · 3 comments · Fixed by #338
Assignees
Labels
infrastructure Terraform, Azure, etc.

Comments

@angela-tran
Copy link
Member

This is a follow-up to #334.

We added two static files to our app with #335 and #336; however, our Azure firewall configuration does not give public access to those files.

We should update the firewall's custom rules to allow us to access those files.

@angela-tran
Copy link
Member Author

angela-tran commented Sep 29, 2023

Maybe the simplest solution is to rename the rule from healthcheck to public_access or something, and then add match conditions for either the static directory or the specific static files.

@thekaveman
Copy link
Member

thekaveman commented Sep 29, 2023

@angela-tran That sounds great, I like that solution 👍

add match conditions for either the static directory or the specific static files.

Shouldn't a match condition for the directory suffice? I wouldn't want to have to maintain a list of files here as well, if we can avoid that.

@angela-tran
Copy link
Member Author

angela-tran commented Sep 29, 2023

Shouldn't a match condition for the directory suffice? I wouldn't want to have to maintain a list of files here as well, if we can avoid that.

Yeah, if we can do it for the static directory, I think that'd be preferred. I think we can do that using the BeginsWith operator

@thekaveman thekaveman self-assigned this Sep 29, 2023
@thekaveman thekaveman moved this from Stretch to In Progress in Digital Services Sep 29, 2023
@thekaveman thekaveman added the infrastructure Terraform, Azure, etc. label Sep 29, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Digital Services Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Terraform, Azure, etc.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants