Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: update group funding source expiry #64

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Conversation

angela-tran
Copy link
Member

This was found while testing cal-itp/benefits#2165 and is needed by that PR.

update_concession_group_funding_source_expiry assumed it would get a list of a GroupFundingSources, but the API documentation says that the response will be

{ "status_code": 204 }

and the QA environment behavior matches the documentation.

@angela-tran angela-tran self-assigned this Jun 13, 2024
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  littlepay/api
  groups.py
Project Total  

This report was generated by python-coverage-comment-action

@angela-tran angela-tran marked this pull request as ready for review June 13, 2024 23:14
@angela-tran angela-tran requested a review from a team as a code owner June 13, 2024 23:14
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change, nice find 👍

@angela-tran angela-tran merged commit 4126d9a into main Jun 13, 2024
3 checks passed
@angela-tran angela-tran deleted the fix/update-concession branch June 13, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants