-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: makes docker usable for production #313
fix: makes docker usable for production #313
Conversation
@krumware for visibility. The Docker build issues (or rather, having to rebuild after doing a docker pull to get the right env vars sorted) is an application issue; Could you elaborate more how this aims to resolve that? |
Would it be helpful to revive #147? |
Hi @emrysal, I just pushed an update; the main goal now is that the image build process installs yarn dependencies and executes yarn build to generate the project bundle using mock environment variables (if you don't have them during the build process fails, this can later be overriden). Finally you have the Docker image built you can bind .env files to pass your runtime variables like this: docker run -p 127.0.0.1:3000:3000/tcp --volume "$(pwd)/.env:/calcom/.env" --volume "$(pwd)/.env.appStore:/calcom/.env.appStore" With this new approach you can have an Official Docker Image that can be deployed individually that doesn't get generated with env keys, this satisfies with the issue that env variables should be runtime only now. |
looking forward to the implementations of these |
so the other PR seems to have closed in favour of this calcom/cal.com#13541 |
If I copy this PR, and follow the instructions, and then run
|
What does this PR do?
This PR removes unnecessary code and processes and updates some commands to build a production bundle.
This PR complements calcom/cal.com#12686, so it should be updated to the latest commit to work correctly once merged.
Fixes #12032
Type of change
How should this be tested?
git clone --recursive https://github.com/calcom/docker.git
docker-compose up