Adds support for basic structs

[armcburney]

Issue

#3

Usage

Adds a SyntaxNode for structs with the following usage:

const structure = new cgl.Struct(qualifier, 'structName', variables);

/**
 * structure.source() =>
 * ----------------------------
 *
 * <qualifierType> struct structName {
 *   // variables
 * };
 */

[davepagurek]

Thoughts:

• we should separate the type and the instance
• probably doesn't need the array type in here if we're going to support arrays of arbitrary types
• this is a good time to separate variables and interfaces

For the Variable and Interface thing: you'll see in your test you've got in as a qualifier on the struct member, which we don't actually want. Instead, the whole struct would have the qualifier, since the struct is the type. What I think we should do is have the type+name be a Variable, and have Interface be a variable+qualifier.

[abhimadan]

I was planning on doing the separation between interface and local variables today, so can we hold off on this pr for now? As Dave said, the tests will make more sense that way.

…

On Nov 11, 2017 1:39 PM, "Dave Pagurek" ***@***.***> wrote: - we should separate the So I think for this we need to do our actual separation of Variable and Interface. You'll see in your test you've got in as a qualifier on the struct member, which we don't actually want. Instead, the whole struct would have the qualifier, since the struct is the type. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <calder-gl/calder#25 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHmdmf6mgLhOxZe9rWwpJ4oSFTDS4Wysks5s1ensgaJpZM4QalZw> .

[armcburney]

Hey @abhimadan, I've almost completed the separation, and I was going to update this PR with it when I was finished.

[abhimadan]

Great!

…

On Nov 11, 2017 2:35 PM, "Andrew McBurney" ***@***.***> wrote: Hey @abhimadan <https://github.com/abhimadan>, I've almost completed the separation, and I was going to update this PR with it when I was finished. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <calder-gl/calder#25 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHmdmaykYVcYCkNfZAuh1e6UQn2oAq1Hks5s1fb4gaJpZM4QalZw> .

[davepagurek]

Why not just store the variable and read these off the variable?

[armcburney]

I didn't want to expose the variable as part of the public interface (even if readonly). Also, I didn't want to breach the law of demeter.

[armcburney]

I can change it if we want, but it would propagate to a lot of changes in the current code which utilizes the old Variable class. I was trying to go for "least amount of changes to other code" while creating this new class.

[davepagurek]

Correct me if I'm wrong but the struct-name at the end makes an instance of the struct, when we really just want the type. e.g.

// define the struct
struct s {
  int x;
};

// now make an instance
s some_instance;

[armcburney]

Oops, my bad - good catch

[davepagurek]

and also change the comment :)

[abhimadan]

Can we rename this class InterfaceVariable? Interface is a really generic name.