Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove node-ui, pull from repo instead #1073

Open
miraclx opened this issue Jan 29, 2025 · 0 comments
Open

Remove node-ui, pull from repo instead #1073

miraclx opened this issue Jan 29, 2025 · 0 comments
Labels
💎 bounty 💎 cli good first issue Good for newcomers medium-priority needs-team-review

Comments

@miraclx
Copy link
Member

miraclx commented Jan 29, 2025

Remove the node-ui, to avoid maintaining multiple the code across multiple fronts.

Since merod needs node-ui to be present when building, we can (as part of a build script), download the latest version of the node-ui repo (if the hash is different), and embed that into the node.

We shouldn't need to download the Node UI all of the time so long as it's cached.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💎 bounty 💎 cli good first issue Good for newcomers medium-priority needs-team-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@miraclx