Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual Only Mode #24

Open
ralphcallaway opened this issue Apr 14, 2020 · 3 comments
Open

Manual Only Mode #24

ralphcallaway opened this issue Apr 14, 2020 · 3 comments

Comments

@ralphcallaway
Copy link
Collaborator

ralphcallaway commented Apr 14, 2020

In a few cases working on projects where all the deployments are handled by a separate process. Would be nice to have a config variable to disable the pull request automation so we don't generate extra build time.

if [ ! -z "$MANUAL_ONLY" ]; then ./sync.sh

@ChuckJonas
Copy link
Collaborator

are you using the pipeline for anything else? Just the production sync?

Could probably just have a separate pipelines file thats significantly reduced and controlled by a yeoman param

@ralphcallaway
Copy link
Collaborator Author

mostly production sync, and hot fix package generation (which is basically none of the PRs if we have a big project, and very few relative to standard release deploys)

kind of thing this is more of an environmental variable thing, what would the benefit of having a reduced pipeline file and related scripts be?

@ChuckJonas
Copy link
Collaborator

Mainly just to take the option off the table if it shouldn't be done due to governance/change management. But if it's still used in some instances, then a ENV makes more sense.

DISABLE_PR_PIPELINE?

There's also already an exit check on the PR pipeline that's hardcoded to make sure it only runs on master. We could make the production branch configurable via ENV and that way you just don't set it if you don't want PR to run.

Downside is that requires an additional one time setup/upgrade step

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants