Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rpaths #439

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Fix rpaths #439

merged 3 commits into from
Sep 16, 2024

Conversation

NQNStudios
Copy link
Collaborator

This adds a 1-file submodule which just contains my python script that detects and fixes broken rpath/dependency references in the app bundles. And extends SConstruct to make sure the submodule is cloned, and call the script automatically.

This theoretically would have fixed the problems behind #192 although the script might not cover every possible edge case.

@CelticMinstrel
Copy link
Member

CelticMinstrel commented Sep 9, 2024

  1. Can we call it after Xcode builds too?
  2. Is there an advantage to making this a submodule rather than just committing the file?

@NQNStudios
Copy link
Collaborator Author

  1. I'm not sure how to set that up. I can't get the xcode build to work either.
  2. That advantage is on my end -- I'm using it for other things, and I only want to maintain it in one place.

@CelticMinstrel
Copy link
Member

I can't get the xcode build to work either.

Oh right, I think you mentioned this before. What was the actual problem with it? Unable to find SFML or something?

@NQNStudios
Copy link
Collaborator Author

Yeah it was something like that. Actually, I might be able to get it to work now using my from-source dependency builds.

@NQNStudios
Copy link
Collaborator Author

I got it working!

@CelticMinstrel CelticMinstrel merged commit 1439fee into calref:master Sep 16, 2024
6 checks passed
@CelticMinstrel
Copy link
Member

CelticMinstrel commented Sep 16, 2024

It seems readlink -f does not work on MacOS 10.15. I also can't find documentation on what it's supposed to do. Can you rewrite your script to use Path.resolve instead?

@NQNStudios
Copy link
Collaborator Author

Yeah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants