Make lastStatusTime mandatory in 200 responses of the status APIs #262
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-murray
requested review from
bigludo7,
sachinvodafone and
akoshunyadi
as code owners
sachinvodafone
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
lastStatusTimeis an optional parameter in the 200 responses of the status APIs. But there is no good reason not to include this parameter. Otherwise, there is the risk of ambiguity as to whether the returned status is still valid. It should be mandatory for any status that is not current, and the simplest way to enforce that is to make it mandatory for all responses.Which issue(s) this PR fixes:
Fixes #138
Special notes for reviewers:
Could be part of Spring'25 meta-release if approved and merged today
Changelog input
Additional documentation
None