Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw more informative error when trying to upload a data type to a stack that doesn't have all of the required containers #950

Open
cmclscourtney opened this issue Oct 5, 2023 · 0 comments · May be fixed by #1452
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers infra-stack Infrastructure issues relating to the stack-manager, stack-data-uploader or the agent templates long-term Something that should be implemented, but not a priority

Comments

@cmclscourtney
Copy link
Collaborator

cmclscourtney commented Oct 5, 2023

For example if Ontop is excluded but trying to upload a mapping we get

Exception in thread "main" java.util.NoSuchElementException: No value present
        at java.base/java.util.Optional.orElseThrow(Unknown Source)
        at com.cmclinnovations.stack.clients.docker.DockerClient.getContainerId(DockerClient.java:546)
        at com.cmclinnovations.stack.clients.docker.ContainerClient.getContainerId(ContainerClient.java:118)
        at com.cmclinnovations.stack.clients.ontop.OntopClient.updateOBDA(OntopClient.java:41)
        at com.cmclinnovations.stack.clients.core.datasets.DatasetLoader.lambda$loadData$7(DatasetLoader.java:145)
        at java.base/java.util.ArrayList.forEach(Unknown Source)
        at com.cmclinnovations.stack.clients.core.datasets.DatasetLoader.loadData(DatasetLoader.java:145)
        at java.base/java.util.Iterator.forEachRemaining(Unknown Source)
        at com.cmclinnovations.stack.clients.core.datasets.DatasetLoader.uploadInputDatasets(DatasetLoader.java:61)
        at com.cmclinnovations.stack.DataUploader.main(DataUploader.java:12)

With which you can figure out what the problem is but worth throwing a clearer error if possible I think.

This could be true of all datatypes and their required stack services

@cmclscourtney cmclscourtney added enhancement New feature or request good first issue Good for newcomers infra-stack Infrastructure issues relating to the stack-manager, stack-data-uploader or the agent templates long-term Something that should be implemented, but not a priority labels Oct 5, 2023
@ChungTingLao ChungTingLao self-assigned this Nov 22, 2024
@ChungTingLao ChungTingLao linked a pull request Jan 22, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers infra-stack Infrastructure issues relating to the stack-manager, stack-data-uploader or the agent templates long-term Something that should be implemented, but not a priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants