Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login Behavior Issue. #255

Open
1 task
HeshamHassan opened this issue Jan 10, 2019 · 10 comments
Open
1 task

Login Behavior Issue. #255

HeshamHassan opened this issue Jan 10, 2019 · 10 comments
Labels

Comments

@HeshamHassan
Copy link
Collaborator

HeshamHassan commented Jan 10, 2019

Scenario:

  1. I am at any page at the website as a guest.
  2. I clicked on Log In
  3. I insert my credential
  4. The website turns me to the homepage.

Required Fix:

  • When I log in to the system, it must turn me back to the same page before logging in.
@Ali-Galal
Copy link
Collaborator

@mohamedMahdyCc update, please

@ahmedelbougha
Copy link

ahmedelbougha commented Feb 10, 2019

@HeshamHassan @mohamedMahdyCc

Scenario1

  • If you are at any page and clicked sign in link
  • You go to sign in page
  • If you are logged in then the normal behavior is to take you to home page

Scenario2

  • If you are at any page and clicked any line that redirects you to sign in page
  • If you are logged in then the normal behavior is to take you to the same page you were there before

Accordingly, this ticket is invalid

@HeshamHassan
Copy link
Collaborator Author

@Ali-Galal
Kindly Advice.

@Ali-Galal
Copy link
Collaborator

@ahmedelbougha what do you mean by invalid?

@ahmedelbougha
Copy link

@Ali-Galal
It's not a bug, it works as expected.

@Ali-Galal
Copy link
Collaborator

@ahmedelbougha I shouldn't lose the page that I was viewing it because I logged in

@ahmedelbougha
Copy link

You are not losing that. I'll send you voice note to make better understanding.

@Ali-Galal
Copy link
Collaborator

ok

@ahmedelbougha
Copy link

ahmedelbougha commented Feb 10, 2019

@Ali-Galal
I edited my comment to correct the mistake.
You can test that scenario in case you are not logged in, in the following:
Course Page > Find out more

@Ali-Galal
Copy link
Collaborator

@HeshamHassan @mohamedMahdyCc

Scenario1

  • If you are at any page and clicked sign in link
  • You go to sign in page
  • If you are logged in then the normal behavior is to take you to home page

Scenario2

  • If you are at any page and clicked any line that redirects you to sign in page
  • If you are logged in then the normal behavior is to take you to the same page you were there before

Accordingly, this ticket is invalid

@HeshamHassan if scenario 2 is correct close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants