Cosmetic #29
Merged
Cosmetic #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Shayan, Thanks a lot for this -- and well done spotting the (more than cosmetic!) README errors :) I'll extend the Dockerfile a bit after merging this. If building Firmament automatically and with sudo privileges, one can set the GerritHub for some reason won't import this pull request, but I'll see if I can bring it in manually. Otherwise, I'll manually merge, since it's tiny anyway. Cheers, |
|
Code reviews here. |
|
All code reviews approved (thanks @ICGog); merging. |
ms705
added a commit
that referenced
this pull request
Jul 10, 2015
Fix README error and add Dockerfile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.