Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Report escalation boundary events that are attached to tasks #942

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jonathanlukas
Copy link
Collaborator

@jonathanlukas jonathanlukas commented Jul 3, 2024

Camunda Community Hub Pull Request Template

Description

This PR fixes the issue that escalation boundary events may currently only be added to subprocesses and call activities in Camunda 8.

Additional context

closes #936

Testing your changes

Existing tests have been adjusted to reflect the changes to the behaviour. Also, a new test has been added to assert that the warning is created.

Types of changes

  • Bug fix (non-breaking change which fixes an existing open issue)
  • New feature (non-breaking change which adds functionality to an extension)
  • Breaking change (fix or feature that would cause existing functionality of an extension to change)
  • Documentation update (changes made to an existing piece of documentation)

Checklist:

  • My code adheres to the syntax used by this extension.
  • My pull request requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the Camunda Community Hub documentation.
  • I have read the Pull Request Process documentation.
  • I have added or suggested tests to cover my changes suggested in this pull request.
  • All new and existing CI/CD tests passed.
  • I will /assign myself this issue, and add the relevant [issue labels] to it if they are not automatically generated by Probot.
  • I will tag @camunda-community-hub/devrel in a new comment on this issue if 30 days have passed since my pull request was opened and I have not received a response from the extension's maintainer.

@jonathanlukas jonathanlukas self-assigned this Jul 3, 2024
Copy link

github-actions bot commented Jul 3, 2024

Test Results

 28 files  + 28   28 suites  +28   1m 17s ⏱️ + 1m 17s
239 tests +239  239 ✅ +239  0 💤 ±0  0 ❌ ±0 
360 runs  +360  360 ✅ +360  0 💤 ±0  0 ❌ ±0 

Results for commit f30d735. ± Comparison against base commit d352043.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Diagram Converter]: Report on Escalation Boundary Events that are not attached to Subprocess / Call Activity
1 participant