Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring 3 upgrade & JSON Logging Support #421

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

shahamit
Copy link

Description

This PR has mainly two important enhancements

  1. Spring 3.1.2 upgrade changes
  2. JSON logging support which enables us to ship the logs to a standard centralised EFK stack

The code changes are tested well and have been running well since a month
*

Related issues

JSON Logging Support as mentioned here.

@CLAassistant
Copy link

CLAassistant commented Oct 17, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ abhinav
❌ amitonlentra


abhinav seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@saig0 saig0 self-requested a review October 19, 2023 08:10
@shahamit
Copy link
Author

I am unable to follow why does the CLA still is not signed since when I click this link I get the message that the agreement is already signed.

@saig0 - Please see the screenshot and guide me on what's pending from my side.
image

@saig0
Copy link
Contributor

saig0 commented Mar 6, 2024

@shahamit please check the author of the commits.

The author of the commit are "abhinav" and "amitonlentra" but both are not linked to your GitHub account. You need to make sure to commit the changes with an email address that is linked to your GitHub account.

I'm very sorry for the delayed answer. 🙇

@saig0 saig0 removed their request for review April 22, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants