Text annotations do not move with annotated target

[nikku]

Describe the bug

Using the space tool I'm used to text annotations moving with the annotated target. Since a couple of releases this does no longer seem to be the case. In fact the annotations stay where they are, and if I use them extensively, then it takes a long time to put them back to their to be expected place:

Note how the behavior changes whether I#m within a participant making space or outside of it.

Steps to reproduce

1. Open text-annotation-move.bpmn
2. Make space within participant, between two tasks
3. See that text annotation position is sticky

Expected behavior

Text annotations move with elements, same as labels.

Environment

• OS: Any
• Camunda Modeler Version: v5.19.0
• Execution Platform: Any
• Installed plug-ins: None

Additional context

Also raised in SUPPORT-22608

SUPPORT-25375
Depends on bpmn-io/bpmn-js#2226

[nikku]

Moving to ready. This is a fallout from a recent improvement, and a real time waster in larger diagrams.

[crobbins215]

Customer has raised this https://jira.camunda.com/browse/SUPPORT-22608 also.

[crobbins215]

Raised in another way as its confusing a customer - bpmn-io/bpmn-js#2215 (comment)

[nikku]

Raised via bpmn-io/bpmn-js#2226, too.

[nikku]

Related to #4492.

[alex-axiobit]

This also happens when you move a pool

[jarekdanielak]

It started happening in v16.4.0.

Specifically with bpmn-io/bpmn-js@ca230c3

[nikku]

Probably worth to checkout bpmn-io/bpmn-js#2049 to understand the original intend (why we worked on bpmn-io/bpmn-js#2078 in the first place).

The space tool, starting from [email protected] / [email protected] is local per default, which in combination causes this issue.

[jarekdanielak]

After a discussion with @nikku, we concluded that text annotations should move when using a local space tool if they are inside of the participant, but NOT when they are outside (unlike external labels which always move with the target).

A possible follow-up is to apply a similar behavior to groups.