fix!: ConceptMapping.coding.code should be a CURIE

close #383 * Use `concept_id` as the CURIE
cancervariants · Dec 31, 2024 · ed970c2 · ed970c2
1 parent f6f200f
commit ed970c2
Show file tree

Hide file tree

Showing 2 changed files with 58 additions and 59 deletions.
diff --git a/src/gene/query.py b/src/gene/query.py
@@ -415,7 +415,7 @@ def _create_concept_mapping(
                 ``NamespacePrefix``
             :return: Concept mapping for identifier
             """
-            source, source_id = concept_id.split(":")
+            source = concept_id.split(":")[0]
 
             try:
                 source = NamespacePrefix(source)
@@ -424,10 +424,9 @@ def _create_concept_mapping(
                 raise ValueError(err_msg) from e
 
             system = NAMESPACE_TO_SYSTEM_URI.get(source, source)
-            code_ = concept_id.upper() if source == NamespacePrefix.HGNC else source_id
 
             return ConceptMapping(
-                coding=Coding(code=code(code_), system=system), relation=relation
+                coding=Coding(code=code(concept_id), system=system), relation=relation
             )
 
         gene_obj = MappableConcept(