Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VRS Variation aliases are not being stored in aliases #459

Closed
korikuzma opened this issue Mar 3, 2025 · 1 comment · Fixed by #460
Closed

VRS Variation aliases are not being stored in aliases #459

korikuzma opened this issue Mar 3, 2025 · 1 comment · Fixed by #460
Assignees
@korikuzma
Labels
bug Something isn't working

Comments

@korikuzma
Copy link
Member

Describe the bug

The transformers are not storing VRS Variation aliases in the aliases field

Steps to reproduce

  1. Run transformer
  2. Look at subjectVariant

Expected behavior

I expect aliases to be stored in aliases

Current behavior

Aliases are stored in extensions

Possible reason(s)

No response

Suggested fix

No response

Branch, commit, and/or version

4a89557

Screenshots

No response

Environment details

NA

Additional details

No response

Contribution

Yes, I can create a PR for this fix.
@korikuzma korikuzma added the bug Something isn't working label Mar 3, 2025
@korikuzma korikuzma self-assigned this Mar 3, 2025
@korikuzma korikuzma mentioned this issue Mar 3, 2025
Merged
@korikuzma korikuzma linked a pull request Mar 4, 2025 that will close this issue
fix: store variation aliases in aliases not extensions #460
Merged
korikuzma added a commit that referenced this issue Mar 7, 2025
@korikuzma
fix: store variation aliases in aliases not extensions (#460)
c6ef41e 
close #459
@github-actions github-actions bot closed this as completed Mar 7, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025

Closed by #460.

korikuzma added a commit that referenced this issue Mar 9, 2025
@korikuzma
fix: store variation aliases in aliases not extensions (#460)
0247270 
close #459
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@korikuzma korikuzma

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: store variation aliases in aliases not extensions cancervariants/metakb
1 participant
@korikuzma