Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use unique artifact names #9

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Conversation

ptoscano
Copy link
Collaborator

@ptoscano ptoscano commented Jan 2, 2024

Starting from v4, the actions/upload-artifact action does not allow the same artifact name uploaded by more than one job.

To overcome that, improve the name of the tito build artifact by:

  • mentioning it contains RPMs
  • adding the container name that generated it

@ptoscano ptoscano force-pushed the ptoscano/unique-artifact-names branch from 4a7c7d9 to fc96dfd Compare January 2, 2024 17:06
Starting from v4, the actions/upload-artifact action does not allow the
same artifact name uploaded by more than one job.

To overcome that, improve the name of the tito build artifact by:
- mentioning it contains RPMs
- adding the container name that generated it
@ptoscano ptoscano force-pushed the ptoscano/unique-artifact-names branch from fc96dfd to e0006e6 Compare January 2, 2024 17:08
Copy link
Contributor

@jirihnidek jirihnidek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@jirihnidek jirihnidek merged commit 70318f1 into main Jan 3, 2024
4 checks passed
@jirihnidek jirihnidek deleted the ptoscano/unique-artifact-names branch January 3, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants