libdnf: small test fixes #3381
Merged
libdnf: small test fixes #3381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test-product-id.c is a test, so there is no need to build it in the libdnf plugin itself. Card ID: CCT-367
cnsnyder
requested review from
a team and
jirihnidek
and removed request for
a team
Coverage (computed on Fedora latest) •
|
Use g_clear_error() so the pointer is also reset to NULL; this avoids potential wrong non-null checks and double frees. Card ID: CCT-368
ptoscano
force-pushed
the
ptoscano/libdnf-test-fixes
branch
from
81a7a05 to
1eaefef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
g_clear_error()instead ofg_error_free()in tests, in case aGError*is reused for more callsCard IDs: CCT-367 CCT-368