Handle URL params for AptRepoFiles #3454
Conversation
There was a problem hiding this comment.
Thanks for the updates, although I'm a bit puzzled why the existing PR was closed (especially since the source branches of the old PR and this one are in ATIX fork...); anyway, this applies what I said back in the old PR: I'm switching it to draft, until the changes in katello are actually merged.
The last time I adopted a previously opened PR, without opening a new PR, this created small frictions in communication (because it was less clear who was talking to whom). There were small annoyances like lack of ability to "resolve threads". So we decided to try re-opening this time around. Probably does not make a major difference. 😉 |
quba42
force-pushed
the
handle_apt_repo_url_params
branch
3 times, most recently
from
6cf5ca0 to
bb752ff
Compare
quba42
force-pushed
the
handle_apt_repo_url_params
branch
from
bb752ff to
5d83cd3
Compare
|
@ptoscano I have tried to answer your questions and implement the suggestions. Since the accompanying Katello change is now merged, I have undrafted the PR. |
|
Sorry for getting very late to this. Would you please rebase it on top of the current Thanks! |
This change allows 'AptRepoFiles' to handle URL parameters for "Components" and "Suites" giving it more flexibility rather than always using a fixed default value.
quba42
force-pushed
the
handle_apt_repo_url_params
branch
from
5d83cd3 to
babeec0
Compare
I rebased on top of main, but I am having trouble locating a Edit: Maybe I am hitting one of these: https://github.com/copilot/c/1178e017-b26c-4557-b504-4220dd923cec |
This change allows 'AptRepoFiles' to handle URL parameters for "Components" and "Suites" giving it more flexibility rather than always using a fixed default value. If the URL supplied by Candlepin does not have any such URL parameters, then everything defaults back to the way it was before.
This change is needed to enable the following Katello feature: Katello/katello#11058
That being said, this change is fully backwards compatible and defines an interface that the Katello side PR will need to respect. The Katello PR is dependent on this PR, not the other way around.
This PR replaces the previous draft PR here: #3223
My apologies for the switch, the idea is to have both this and the Katello PR in the same hand, so I can better pursue the completion of both related PRs.