Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wales #10

Open
JustSteveKing opened this issue Nov 10, 2020 · 9 comments
Open

Wales #10

JustSteveKing opened this issue Nov 10, 2020 · 9 comments
Assignees
Labels
new country Requesting a new logomark

Comments

@JustSteveKing
Copy link

Is you request a new country in the list?
Not yet!

Your country community links
We only have a general PHP community currently (which I organise) but we are full of Laravel Devs!

Additional context
We have a dragon on our flag, so feel we represent early Laravel very well

@JustSteveKing JustSteveKing added the new country Requesting a new logomark label Nov 10, 2020
@caneco
Copy link
Owner

caneco commented Nov 12, 2020

Here's a preview 🏴󠁧󠁢󠁷󠁬󠁳󠁿

image




But to be honest…

I don't know how to place the assets folder 🤔
Should I place it:

  • A) in a specials/ folder
  • B) in a new folder wls inside the existing uk/ folder?
  • C) in a new folder uk-wls

From the 3 options I'm considering either B) or C)

@JustSteveKing
Copy link
Author

It mainly depends on the convention you are following, from what I can see you are following country codes in an ISO format, I would recommend "CY" as this is the typical language code for Welsh.

https://en.m.wikipedia.org/wiki/Welsh_language

@caneco
Copy link
Owner

caneco commented Nov 13, 2020

@JustSteveKing I'm trying to keep the ISO 3166-1 ALPHA-2 … but TBH I now see that failed big time with the UK Logomark 😅

With that in mind, CY should be Cyprus 🤔

@JustSteveKing
Copy link
Author

Damn, these things are tricky! Either way, you're doing an awesome job!

You could look at ISO_3166-2 which are country short codes - but then you still hit the UK issue.

Perhaps stick with the pattern you are already following and then: area-country such as uk-cy for Wales and uk-ire for Northern Ireland? Do it which ever way works for you 😄

@caneco
Copy link
Owner

caneco commented Nov 17, 2020

@JustSteveKing I'm planing to move the UK folder to GB and use the name "Great Britain" instead of "UK".

Can I have your comments on the PR #27?

– Thanks

@JustSteveKing
Copy link
Author

That makes perfect sense to me @caneco and I've added a comment on the PR for you. But to log it here also:

I think moving UK to GB makes a lot of sense as it leave you open to expand further should you need to. Also it's a common standard being used, which as someone who loves standards can 100% appreciate!

Thanks for your awesome work as always!

@caneco
Copy link
Owner

caneco commented Nov 19, 2020

(late response; sorry)

@JustSteveKing thanks for the feedback and validation of the decision 👍

@JustSteveKing
Copy link
Author

No problems @caneco anytime!

@JustSteveKing
Copy link
Author

@caneco did this one ever get merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new country Requesting a new logomark
Projects
None yet
Development

No branches or pull requests

2 participants