-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wales #10
Comments
It mainly depends on the convention you are following, from what I can see you are following country codes in an ISO format, I would recommend "CY" as this is the typical language code for Welsh. |
@JustSteveKing I'm trying to keep the ISO 3166-1 ALPHA-2 … but TBH I now see that failed big time with the UK Logomark 😅 With that in mind, CY should be Cyprus 🤔 |
Damn, these things are tricky! Either way, you're doing an awesome job! You could look at ISO_3166-2 which are country short codes - but then you still hit the UK issue. Perhaps stick with the pattern you are already following and then: |
@JustSteveKing I'm planing to move the UK folder to GB and use the name "Great Britain" instead of "UK". Can I have your comments on the PR #27? – Thanks |
That makes perfect sense to me @caneco and I've added a comment on the PR for you. But to log it here also: I think moving UK to GB makes a lot of sense as it leave you open to expand further should you need to. Also it's a common standard being used, which as someone who loves standards can 100% appreciate! Thanks for your awesome work as always! |
(late response; sorry) @JustSteveKing thanks for the feedback and validation of the decision 👍 |
No problems @caneco anytime! |
@caneco did this one ever get merged? |
Is you request a new country in the list?
Not yet!
Your country community links
We only have a general PHP community currently (which I organise) but we are full of Laravel Devs!
Additional context
We have a dragon on our flag, so feel we represent early Laravel very well
The text was updated successfully, but these errors were encountered: