Renaming UK to GB #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
I think this makes a lot of sense, and doesn't close anything off should you want/need to expand. It also has the added benefit of being a common standard when it comes to country codes. |
|
@JustSteveKing thanks for the validation! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In favor to follow the ISO 3166-1 ALPHA-2, aka the "PSR of the Country Codes", I have this PR that will make the following changes:
uktogb;Also, along with the new country code the named assets now spell "Great Britain" instead of "UK".
⁉ Any comments or remarks about this change?
Before
After
Hopefully with this change the Wales Logomark (#10) can finally join the collection 🏴