Sort plugin breaks inheritance of .splice()

[justinbmeyer]

@akagomez commented on Tue Jan 19 2016

Array.prototype.splice is called:

https://github.com/canjs/canjs/blob/master/list/sort/sort.js#L379

It should use oldSplice:

https://github.com/canjs/canjs/blob/master/list/sort/sort.js#L404

---

@rjgotten commented on Wed Jan 20 2016

@akagomez
Isn't it using the direct Array.prototype.splice in that location exactly because it's necessary to avoid the change events that can.List.prototype.splice triggers?

---

@akagomez commented on Wed Jan 20 2016

I don't suspect so. Triggering "change" events is fine. Binding to them should be avoided.

The sort plugin triggers "add" events in the same way can.List.prototype.splice does:

https://github.com/canjs/canjs/blob/master/list/sort/sort.js#L382
https://github.com/canjs/canjs/blob/master/list/list.js#L334