Some issues with test case power-management/lid_close_suspend_open #1080
Assignees
Labels
bug
Something isn't working
Comments
|
Thank you for reporting us your feedback! The internal ticket has been created: https://warthogs.atlassian.net/browse/CHECKBOX-1313.
|
eugene-yujinwu
added a commit
to eugene-yujinwu/checkbox
that referenced
this issue
Mar 20, 2024
…_suspend_open (bugfix) (canonical#1080) - Include a note to ensure the test is executed at the appropriate time - Fix the typo in the test order number - Remove functionally similar test cases power-management/lid from the test plan - Adjust the place of test case to avoid running it just after the suspend case
eugene-yujinwu
added a commit
to eugene-yujinwu/checkbox
that referenced
this issue
Mar 22, 2024
…_suspend_open (bugfix) (canonical#1080) - Include a note to ensure the test is executed at the appropriate time - Fix the typo in the test order number - Adjust the place of test case to avoid running it just after the suspend case
eugene-yujinwu
added a commit
to eugene-yujinwu/checkbox
that referenced
this issue
May 24, 2024
…_suspend_open (bugfix) (canonical#1080) - Include a note to ensure the test is executed at the appropriate time - Fix the typo in the test order number - Remove functionally similar test cases power-management/lid from the test plan - Adjust the place of test case to avoid running it just after the suspend case
eugene-yujinwu
added a commit
to eugene-yujinwu/checkbox
that referenced
this issue
Jun 21, 2024
…_suspend_open (bugfix) (canonical#1080) - Include a note to ensure the test is executed at the appropriate time - Fix the typo in the test order number - Remove functionally similar test cases power-management/lid from the test plan - Adjust the place of test case to avoid running it just after the suspend case
eugene-yujinwu
added a commit
that referenced
this issue
Jun 26, 2024
…_suspend_open (bugfix) (#1080) - Include a note to ensure the test is executed at the appropriate time - Fix the typo in the test order number - Remove functionally similar test cases power-management/lid from the test plan - Adjust the place of test case to avoid running it just after the suspend case Add test power-management/lid back per Clair's comments Check the last suspend within the time of HoldoffTimeoutUSec as the review advised. Change the script per the new comments from Hanhsuan change the lid_close_suspend_open.sh per Stanley's advice Co-authored-by: stanley31huang <[email protected]>
pieqq
added a commit
that referenced
this issue
Jul 4, 2024
…1093) * Fix some issues related with the test case power-management/lid_close_suspend_open (bugfix) (#1080) - Make sure the test is executed at the appropriate time (i.e. not right after resuming the device) - Fix the typo in the test order number - Remove functionally similar test cases power-management/lid from the test plan - Adjust the place of test case to avoid running it just after the suspend case * Add test power-management/lid back per Clair's comments * Check the last suspend within the time of HoldoffTimeoutUSec as the review advised. * Change the script per the new comments from Hanhsuan * change the lid_close_suspend_open.sh per Stanley's advice Co-authored-by: stanley31huang <[email protected]> * Fix the error in ShellcheckTests * Fix a wait time calculation issue and improve the PR per Pierre's comments Co-authored-by: Pierre Equoy <[email protected]> --------- Co-authored-by: stanley31huang <[email protected]> Co-authored-by: Pierre Equoy <[email protected]>
|
This has been fixed by #1093 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Description
There are some issues related to the test case power-management/lid_close_suspend_open:
A typo that make the test steps jump from 3 to 5.
There is a HoldoffTimeoutSec which will "Specifies a period of time after system startup or system resume in which systemd will hold off on reacting to lid events....Defaults to 30s. " So if we run this test just after a resume from suspend, it will failed. Please see LP bugs: LP:2042406, LP:2047136. Maybe we need add some notes to make the tester aware of this information.
This test case seems to be redundant with another test case power-management/lid. Each of them listed in the test plan after-suspend-graphics-integrated-gpu-cert-manual , so it's recursively included in the test plan client-cert-desktop-22-04-manual. Maybe we can remove one of them.
A improvement suggestion from Kent: Maybe we could move this test case away from the suspend_advanced_auto test case, to avoid the situation that run this test case just after the resume from suspend.
To Reproduce
checbox-cli run com.canonical.certification::power-management/lid_close_suspend_open
Environment
checkbox: 4.0.0.dev139. Lenovo Desktop OEM image 1016-oem kernel
Relevant log output
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: