NM activator/bring_up_interfaces: reload and bring up individual network conns #6073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ork conns Reloading the network manager service is equivalent to "nmcli reload" and this command only reloads the global .conf files and DNS config, not connections. This means changes to connection files will not take effect. For those to take effect, we need "nmcli conn load/reload" and then "nmcli conn up". Thus, reloading network manager as well as reloading the connections are required to cover all cases. Also see canonical#5512 (comment) While at it, rename "reload-or-try-restart" -> "try-reload-or-restart" since the former is legacy and the later is the officially documented sub-command. Fixes: canonicalGH-6064 Fixes: bde913a ("fix(NetworkManager): Fix network activator") Signed-off-by: Ani Sinha <[email protected]>
|
@holmanb kindly take a look and comment |
TheRealFalcon
approved these changes
Mar 5, 2025
There was a problem hiding this comment.
LGTM, but I'll let @holmanb chime in in case there's any additional context I'm missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Reloading the network manager service is equivalent to "nmcli reload" and this command only reloads the global .conf files and DNS config, not connections. This means changes to connection files will not take effect. For those to take effect, we need "nmcli conn load/reload" and then "nmcli conn up". Thus, reloading network manager as well as reloading the connections are required to cover all cases.
Also see #5512 (comment)
While at it, rename "reload-or-try-restart" -> "try-reload-or-restart" since the former is legacy and the later is the officially documented sub-command.
Fixes: GH-6064
Fixes: bde913a ("fix(NetworkManager): Fix network activator")
Merge type