Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow colcon release-in-container to use more that 1 cpu #24

Open
aosmw opened this issue Jun 10, 2024 · 3 comments
Open

Allow colcon release-in-container to use more that 1 cpu #24

aosmw opened this issue Jun 10, 2024 · 3 comments
Labels
wontfix This will not be worked on

Comments

@aosmw
Copy link

aosmw commented Jun 10, 2024

I noticed that the colcon release-in-container does a build that only uses 1 cpu.

Here is a related discussion that bloom is that way in order to make it work for the ros build farm use case.
ros-infrastructure/bloom#643

@Guillaumebeuzeboc
Copy link
Collaborator

Thanks for the feedback and the link.
In the case of the release-in-container we are building the packages in a deterministic order, so that shouldn't cause any issue.
Now I am more wondering if we should and how to integrate such a change in release-in-container.

I would probably be simpler if Bloom could get released with that change, since the project is not meant to diverge from upstream.

@aosmw
Copy link
Author

aosmw commented Jun 10, 2024

The change, IF you decided to do it, could be allow debian/compat to be overwritten to a number (10 or even 13). other than what it currently defaults to after the bloom-generate call,

Here is a script where it is done with a simple echo 11 > debian/compat which is a comment in
ros-industrial/industrial_ci#697 (comment)

Turns out that 11 is not recommended. 10 would be enough to satisfy this issue. Automatically do the build in parallel.

@artivis
Copy link
Contributor

artivis commented Jun 11, 2024

I agree that I would prefer this to land in bloom rather than as a workaround here.

Linking the related bloom ticket: ros-infrastructure/bloom#643.

@artivis artivis added the wontfix This will not be worked on label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants