Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-in-container appears to assume package_name == pkg directory #29

Open
gavanderhoorn opened this issue Aug 22, 2024 · 0 comments · May be fixed by #33
Open

release-in-container appears to assume package_name == pkg directory #29

gavanderhoorn opened this issue Aug 22, 2024 · 0 comments · May be fixed by #33
Assignees
@Guillaumebeuzeboc
Labels
bug Something isn't working

Comments

@gavanderhoorn
Copy link

As per title.

Looking at _bloom_generate(..) fi:

colcon-in-container/colcon_in_container/verb/release_in_container.py

Lines 88 to 92 in 39379e1

def _bloom_generate(self, package_name, generator):
logger.info(f'Bloom generating {package_name}')
return self.provider.execute_commands([
f'cd /ws/src/{package_name}',
f'bloom-generate {generator}'])

in case package a is actually in dir b (on disk), this fails for me (as cd /ws/src/a will not work).

Technically there is no requirement for a ROS package to be hosted in a directory with the same name as the one listed in the manifest. It's often the case though, but would be nice to not assume it.
@artivis artivis added bug Something isn't working labels Sep 19, 2024
@Guillaumebeuzeboc Guillaumebeuzeboc self-assigned this Dec 12, 2024
@Guillaumebeuzeboc Guillaumebeuzeboc linked a pull request Dec 13, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Guillaumebeuzeboc Guillaumebeuzeboc

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/package name canonical/colcon-in-container
3 participants
@gavanderhoorn @artivis @Guillaumebeuzeboc