Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow user to set listen address and port #55

Merged
merged 4 commits into from
Oct 31, 2023
Merged

allow user to set listen address and port #55

merged 4 commits into from
Oct 31, 2023

Conversation

dstathis
Copy link
Contributor

Issue

Users need to be able to set the listen address and port of the https server. #54

Solution

Create a config option and forward it to waitress-serve.

Testing Instructions

  1. Change the listen address in the config file.
  2. Run COS Alerter.
  3. Check that it is listening on the correct port.

Release Notes

Users can now set a custom listen address for the http server.

@dstathis dstathis requested review from mmkay and IbraAoad October 26, 2023 14:04
Copy link

@mmkay mmkay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks fine, however I'm wondering if it wouldn't be useful to add a test case for testing the newly exposed config property?

@dstathis
Copy link
Contributor Author

The PR looks fine, however I'm wondering if it wouldn't be useful to add a test case for testing the newly exposed config property?

I considered this but decided the feature is trivial enough.

@dstathis dstathis merged commit e058422 into main Oct 31, 2023
7 checks passed
@dstathis dstathis deleted the listen_address branch October 31, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants