Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin xmlsec to 1.3.13 #34

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Pin xmlsec to 1.3.13 #34

merged 2 commits into from
Apr 25, 2024

Conversation

arturo-seijas
Copy link
Contributor

@arturo-seijas arturo-seijas commented Apr 25, 2024 •
edited
Loading

Applicable spec:
N/A

Overview

Pin xmlsec to 1.3.13

Rationale

xmlsec > 1.3.13 requires a different set pf apt packages to work

Module Changes

N/A

Checklist

  • The contributing guide was applied
  • The documentation is generated using src-docs
  • The PR is tagged with appropriate label (urgent, trivial, complex)

@arturo-seijas arturo-seijas requested a review from a team as a code owner April 25, 2024 09:57
mthaddon
mthaddon reviewed Apr 25, 2024
View reviewed changes
Copy link

@mthaddon mthaddon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also update the README to include build instructions, and can we remove setup.py/setup.cfg if we're using poetry now?

@arturo-seijas
Copy link
Contributor Author

Can we also update the README to include build instructions, and can we remove setup.py/setup.cfg if we're using poetry now?

I'll open another PR for this

@arturo-seijas arturo-seijas requested a review from mthaddon April 25, 2024 10:09
@arturo-seijas arturo-seijas merged commit b5003a0 into main Apr 25, 2024
20 checks passed
@arturo-seijas arturo-seijas deleted the pin-xmlsec-to-1.3.13 branch April 25, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mthaddon mthaddon mthaddon approved these changes

@yanksyoon yanksyoon yanksyoon approved these changes

@Thanhphan1147 Thanhphan1147 Thanhphan1147 approved these changes

Assignees
No one assigned
Labels
trivial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arturo-seijas @mthaddon @yanksyoon @Thanhphan1147