Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charm is happily "active/idle" even when workload cannot reach any datasources #305

Open
sed-i opened this issue Feb 29, 2024 · 3 comments

Comments

@sed-i
Copy link
Contributor

sed-i commented Feb 29, 2024

Enhancement Proposal

Data not appearing on the Grafana panel due to a firewall blocking ports from related datasources.
This was not initially obvious because, in other deployments, the COS subnet was the same as the OpenStack management subnet, so we never ran into firewall issues. However, this time, the COS subnet was different, and it took us a while to figure this out. -- @qch2012

It could be handy if the charm blocks when the datasource URLs are not routeable/reachable. Some impl ideas:

  • Check on update status, because at deploy time this check could be more racy than on update-status.
  • Have a custom pebble notice running in the background that would wake up the charm on "rising/falling edge".

Very similar problem to canonical/grafana-agent-operator#57.

@simskij
Copy link
Member

simskij commented Mar 15, 2024

I'm not sure I agree that this is a charm concern. 🤔 Let's discuss it more with the team

@mmkay
Copy link
Contributor

mmkay commented May 9, 2024

It's likely the same logic as we need in grafana-agent-operator, but it's not clear yet whether it's a good idea to block the Grafana charm.

@lucabello
Copy link
Contributor

We should do this with Pebble checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants