feat: use TLS lib v4 to manage certs #385
Open
+1,761
−2,408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
lib/charms/tls_certificates_interface/v4/tls_certificates.py
Dismissed
Show dismissed
Hide dismissed
lib/charms/tls_certificates_interface/v4/tls_certificates.py
Dismissed
Show dismissed
Hide dismissed
lib/charms/tls_certificates_interface/v4/tls_certificates.py
Dismissed
Show dismissed
Hide dismissed
lib/charms/tls_certificates_interface/v4/tls_certificates.py
Dismissed
Show dismissed
Hide dismissed
|
I believe the test failures are unrelated to this PR, but I don't have permission to re-run them. Specifically, |
|
Hey Daniel, thanks a lot for this PR! I'll take a look at the tests :) |
lucabello
changed the title
DanielArndt
force-pushed
the
tls-certificates-v4
branch
from
acc3db3 to
a1abcd7
Compare
|
So the failing upgrade test seemed to be a result of removing the peer relation (a1abcd7). It seems as though Juju sometimes "informs" the charm this relation is being removed before the code is actually refreshed. This caused the old code (cert_handler) to fail as the relation it was expecting to exist no longer existed. The possible paths forward AFAICT:
|
|
I'll ask to prioritize this in the next pulse! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #326
Reduce the code that must be managed by the o11y team.
Solution
Use the latest version of the TLS Interface Library (V4)
Context
The new version of the library attempts to encapsulate the boilerplate code needed to manage TLS certificates. This should largely (or entirely) replace cert_handler in most projects.
I'm making this PR to show how easy it should be to upgrade. I hope that using this as a template, you will be able to retire
cert_handlerentirely from every project. If not, please provide feedback on what could be improved!Testing Instructions
Since I am largely unfamiliar with the project, I have relied on the e2e tests.
Upgrade Notes
This change will force a new private key for the charm and therefore request a new certificate. If the certificate is manually issued, it may need to be re-issued upon upgrade.