Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StrategyABC should not provide default value for _name #33

Open
rgildein opened this issue Jul 6, 2023 · 0 comments
Open

StrategyABC should not provide default value for _name #33

rgildein opened this issue Jul 6, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@rgildein
Copy link
Contributor

rgildein commented Jul 6, 2023

I believe that the StrategyABC should no provide default value for _name. At the same time the property name return type is not HWTool (Enum), but string.

Suggestion to fix:

class StrategyABC(ABC):  # pylint: disable=R0903
    """Basic strategy."""

    _name: str

    @property
    def name(self) -> str:
        """Name."""
        return self._name
@Pjack Pjack added the enhancement New feature or request label Feb 29, 2024
@Pjack Pjack added the good first issue Good for newcomers label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants