kfp-profile-controller's crd_manifests.yaml.j2 incorrectly includes istio objects in 1.8-updates-dev-branch
#373
Labels
bug
Something isn't working
Comments
This was referenced Nov 3, 2023
|
closed by #376 |
DnPlas
added a commit
that referenced
this issue
Jun 5, 2024
This commit ensures the controller is bootstrapped with version 3.5.0 instead of the default as we have found issues with it. This is a workaround for canonical/bundle-kubeflow#921. Fixes #373
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Description
on the
1.8-updates-dev-branch, kfp-profile-controller'scrd_manifests.yaml.j2includes references to istiodestinationrulesandauthorizationpoliciesobjects. This was introduced by #331 which updated the file to be more consistent with upstream.These istio objects are intentionally omitted from charmed kubeflow because we don't currently use them in the kfp-profile-controller (see our sync.py). #331 introduced a bug in the form of the metacontroller having a dependency on istio.
To fix this, we can revert #331's changes to this file.
To Reproduce
Environment
1.8-updates-dev-branchRelevant log output
Additional context
No response
The text was updated successfully, but these errors were encountered: