From 245ea90d5888e75c0ef96c5d949a879f28c7b1d9 Mon Sep 17 00:00:00 2001 From: Simon Deziel Date: Wed, 1 May 2024 20:41:31 -0400 Subject: [PATCH] github: more elegantly report image-test failures Previously, a failure from `./bin/test-image` would abort immediatly due to `set -e`. Now, we get a chance of echo'ing that it failed. Signed-off-by: Simon Deziel --- .github/actions/image-test/action.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/actions/image-test/action.yml b/.github/actions/image-test/action.yml index f0f3060de..dbfa3eebc 100644 --- a/.github/actions/image-test/action.yml +++ b/.github/actions/image-test/action.yml @@ -41,12 +41,10 @@ runs: exit 1 fi - ./bin/test-image "${TYPE}" "${DISTRO}" "${RELEASE}" "${VARIANT}" "${TARGET}" - - if [ "$?" = "0" ]; then + if ./bin/test-image "${TYPE}" "${DISTRO}" "${RELEASE}" "${VARIANT}" "${TARGET}"; then echo "==> PASS: ${TEST_ID}" exit 0 fi echo "==> FAIL: ${TEST_ID}" - exit 0 + exit 1