From 15ad72f05365b15846a65809433bf2d246830641 Mon Sep 17 00:00:00 2001
From: Simon Deziel <simon.deziel@canonical.com>
Date: Tue, 8 Oct 2024 15:27:23 -0400
Subject: [PATCH] github: move `make doc-linkcheck` to Tiobe TICS job

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
---
 .github/workflows/tests.yml | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
index 1f8bfad17f5f..d93a4fac8f9f 100644
--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -417,6 +417,13 @@ jobs:
           calc: ALL
           tmpdir: /tmp/tics
 
+      # Verify doc links work
+      - name: Run link checker
+        shell: 'script -q -e -c "export TERM=xterm-256color; bash {0}"'
+        run: |
+          set -eux
+          make doc-linkcheck
+
   client:
     name: Client
     strategy:
@@ -547,13 +554,9 @@ jobs:
           fail-on-error: true
           woke-args: "*.md **/*.md -c https://github.com/canonical/Inclusive-naming/raw/main/config.yml"
 
-      - name: Run link checker
-        # Run link checker on PRs only
-        if: ${{ github.event_name != 'push' }}
-        shell: 'script -q -e -c "export TERM=xterm-256color; bash {0}"'
-        run: |
-          set -eux
-          make doc-linkcheck
+      # XXX: not running `make doc-linkcheck` here as it often fails due to
+      # remote sites applying rate limits. It is instead ran on a schedule
+      # along with Tiobe TICS
 
       - name: Upload documentation artifacts
         if: always()