-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't fail when notifiying a server that is shutting down when using NotifyAlive #13811
Comments
MggMuggins
added a commit
to MggMuggins/lxd
that referenced
this issue
Aug 6, 2024
...that is shutting down when using NotifyAlive. Fixes canonical#13811 Signed-off-by: Wesley Hershberger <[email protected]>
MggMuggins
added a commit
to MggMuggins/lxd
that referenced
this issue
Aug 7, 2024
...that is shutting down when using NotifyAlive. Fixes canonical#13811 Signed-off-by: Wesley Hershberger <[email protected]>
MggMuggins
added a commit
to MggMuggins/lxd
that referenced
this issue
Aug 7, 2024
...that is shutting down when using NotifyAlive. Fixes canonical#13811 Signed-off-by: Wesley Hershberger <[email protected]>
MggMuggins
added a commit
to MggMuggins/lxd
that referenced
this issue
Aug 7, 2024
...that is shutting down when using NotifyAlive. Fixes canonical#13811 Signed-off-by: Wesley Hershberger <[email protected]>
MggMuggins
added a commit
to MggMuggins/lxd
that referenced
this issue
Aug 7, 2024
...that is shutting down when using NotifyAlive. Fixes canonical#13811 Signed-off-by: Wesley Hershberger <[email protected]>
tomponline
added a commit
that referenced
this issue
Aug 19, 2024
…otifyAlive (#13883) Fixes #13811 There doesn't seem to be a well-established pattern for differentiating between error types other than `strings.Contains`. I'd be happy to drop something like [`IsConnectionError` ](https://github.com/canonical/lxd/blob/main/shared/network.go#L53) in a new file `shared/errors.go` if you're concerned about fragility when comparing error messages. LXD-1371
tomponline
pushed a commit
to tomponline/lxd
that referenced
this issue
Aug 20, 2024
...that is shutting down when using NotifyAlive. Fixes canonical#13811 Signed-off-by: Wesley Hershberger <[email protected]>
kadinsayani
pushed a commit
to kadinsayani/lxd
that referenced
this issue
Aug 28, 2024
...that is shutting down when using NotifyAlive. Fixes canonical#13811 Signed-off-by: Wesley Hershberger <[email protected]>
hamistao
pushed a commit
to hamistao/lxd
that referenced
this issue
Sep 4, 2024
...that is shutting down when using NotifyAlive. Fixes canonical#13811 Signed-off-by: Wesley Hershberger <[email protected]>
tomponline
pushed a commit
to tomponline/lxd
that referenced
this issue
Sep 13, 2024
...that is shutting down when using NotifyAlive. Fixes canonical#13811 Signed-off-by: Wesley Hershberger <[email protected]>
tomponline
pushed a commit
to tomponline/lxd
that referenced
this issue
Sep 13, 2024
...that is shutting down when using NotifyAlive. Fixes canonical#13811 Signed-off-by: Wesley Hershberger <[email protected]>
tomponline
pushed a commit
to tomponline/lxd
that referenced
this issue
Sep 13, 2024
...that is shutting down when using NotifyAlive. Fixes canonical#13811 Signed-off-by: Wesley Hershberger <[email protected]>
tomponline
pushed a commit
to tomponline/lxd
that referenced
this issue
Sep 13, 2024
...that is shutting down when using NotifyAlive. Fixes canonical#13811 Signed-off-by: Wesley Hershberger <[email protected]>
tomponline
pushed a commit
to tomponline/lxd
that referenced
this issue
Sep 13, 2024
...that is shutting down when using NotifyAlive. Fixes canonical#13811 Signed-off-by: Wesley Hershberger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If a cluster notification is sent to all alive members during the shutdown process of a LXD server then the notification process fails.
If the notifier could detect that the response to the request was not a failure to handle the specific notification, but that it failed due to the server shutting down, then we could treat this the same as the server not being alive, and not fail the entire notification process.
This was originally reported from the Anbox team when one of their cluster members was snap refreshed during adding a certificate:
The text was updated successfully, but these errors were encountered: