Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote-build broken with shallow clones #4479

Closed
mr-cal opened this issue Dec 5, 2023 · 2 comments
Closed

remote-build broken with shallow clones #4479

mr-cal opened this issue Dec 5, 2023 · 2 comments
Labels
bug Actual bad behavior that don't fall into maintenance or documentation

Comments

@mr-cal
Copy link
Collaborator

mr-cal commented Dec 5, 2023

Bug Description

Remote-build in snapcraft 8 doesn't work with shallow clones.

To Reproduce

git clone https://github.com/telegramdesktop/tdesktop --depth=1
cd tdesktop
snapcraft remote-build

Environment

n/a

snapcraft.yaml

n/a

Relevant log output

2023-12-05 08:58:34.873 Starting Snapcraft 8.0.0.post2+git662af4c0
2023-12-05 08:58:34.874 snapcraft remote-build is experimental and is subject to change - use with caution.
2023-12-05 08:58:34.874 Emitter: Pausing control of the terminal
2023-12-05 08:58:37.625 Emitter: Resuming control of the terminal
2023-12-05 08:58:37.683 Got base 'core22' from 'snap/snapcraft.yaml'
2023-12-05 08:58:37.683 Running new remote-build because environment variable 'SNAPCRAFT_REMOTE_BUILD_STRATEGY' is 'disable-fallback'
2023-12-05 08:58:37.683 Setting up launchpad environment
2023-12-05 08:58:37.706 Using project name 'telegram-desktop' from 'snap/snapcraft.yaml'
2023-12-05 08:58:37.947 Setting up launchpad environment.
2023-12-05 08:58:47.145 Looking for existing build
2023-12-05 08:58:47.291 No existing build found
2023-12-05 08:58:47.292 If interrupted, resume with: 'snapcraft remote-build --recover --build-idsnapcraft-telegram-desktop-7de9b03b32e10917bf39ab9b4cf15ad7'
2023-12-05 08:58:47.292 Starting build
2023-12-05 08:58:48.770 Cached project at /home/developer/.cache/snapcraft/remote-build/snapcraft-telegram-desktop-7de9b03b32e10917bf39ab9b4cf15ad7/repo
2023-12-05 08:58:48.912 creating git repo: name=snapcraft-telegram-desktop-7de9b03b32e10917bf39ab9b4cf15ad7, owner=/~mr-cal, target=/~mr-cal
2023-12-05 08:58:49.711 Sending build data to Launchpad: https://mr-cal:<token>@git.launchpad.net/~mr-cal/+git/snapcraft-telegram-desktop-7de9b03b32e10917bf39ab9b4cf15ad7/
2023-12-05 08:58:49.713 Resolved reference 'refs/heads/dev' for name 'HEAD'
2023-12-05 08:58:49.713 Pushing 'HEAD' to remote 'https://mr-cal:<token>@git.launchpad.net/~mr-cal/+git/snapcraft-telegram-desktop-7de9b03b32e10917bf39ab9b4cf15ad7/' with refspec 'refs/heads/dev:refs/heads/main'.
2023-12-05 08:58:58.136 Registering snap job on Launchpad...
2023-12-05 08:58:58.136 url=https://launchpad.net//~mr-cal/+snap/snapcraft-telegram-desktop-7de9b03b32e10917bf39ab9b4cf15ad7
2023-12-05 08:58:58.716 Issuing build request on Launchpad...
2023-12-05 08:58:59.512 Waiting on Launchpad build request...
2023-12-05 08:58:59.513 status=Pending error=None
2023-12-05 08:59:00.868 Removing snap job from Launchpad...
2023-12-05 08:59:01.458 Deleting source repository from Launchpad...
2023-12-05 08:59:02.002 remote-build error: Cannot find snapcraft.yaml in https://[email protected]/~mr-cal/+git/snapcraft-telegram-desktop-7de9b03b32e10917bf39ab9b4cf15ad7/ main
2023-12-05 08:59:02.002 Full execution log: '/home/developer/.local/state/snapcraft/log/snapcraft-20231205-085834.873090.log'

Additional context

No response

@mr-cal mr-cal added the bug Actual bad behavior that don't fall into maintenance or documentation label Dec 5, 2023
@syu-w
Copy link
Contributor

syu-w commented Dec 7, 2023

This one broken without shallow clone:

2023-12-06 19:21:04.854 Writing objects:  99% (214073/214090), 209.90 MiB | 356.00 KiB/s                                                 
2023-12-06 19:21:04.864 Writing objects: 100% (214090/214090), 209.90 MiB | 356.00 KiB/s                                                 
2023-12-06 19:21:04.875 Writing objects: 100% (214090/214090), 209.95 MiB | 298.00 KiB/s, done.                                          
2023-12-06 19:21:04.885 Total 214090 (delta 179712), reused 214089 (delta 179712), pack-reused 0                                         
2023-12-06 19:21:10.832 Registering snap job on Launchpad...                                                                             
2023-12-06 19:21:10.832 url=https://launchpad.net//~syu-w/+snap/snapcraft-telegram-desktop-8c436ac75b2d4d67c17688158a7662e4              
2023-12-06 19:21:11.521 Issuing build request on Launchpad...                                                                            
2023-12-06 19:21:12.977 Waiting on Launchpad build request...                                                                            
2023-12-06 19:21:12.977 status=Pending error=None                                                                                        
2023-12-06 19:21:14.626 Removing snap job from Launchpad...                                                                              
2023-12-06 19:21:15.106 Deleting source repository from Launchpad...                                                                     
2023-12-06 19:21:15.633 remote-build error: Cannot find snapcraft.yaml in https://[email protected]/~syu-w/+git/snapcraft-telegram-desktop-8c436ac75b2d4d67c17688158a7662e4/ main                                                                             

@mr-cal
Copy link
Collaborator Author

mr-cal commented Feb 7, 2024

Fixed via #4498

@mr-cal mr-cal closed this as completed Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Actual bad behavior that don't fall into maintenance or documentation
Projects
None yet
Development

No branches or pull requests

2 participants