Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Skype #25

Open
moriel5 opened this issue Sep 25, 2020 · 9 comments
Open

Update Skype #25

moriel5 opened this issue Sep 25, 2020 · 9 comments
Labels
enhancement New feature or request

Comments

@moriel5
Copy link
Contributor

moriel5 commented Sep 25, 2020

Skype is currently out of date, and needs to be updated.
As mentioned in issue #22, I am willing to contribute.

As I have maintained my own Skype and Skype-Next packages in the past, I am willing to step up and maintain the Skype package (and given permission, also Skype-Next).

@cantalupo555
Copy link
Owner

Hello
You just need to update folder this: https://github.com/cantalupo555/repo-solus/tree/master/package/skype
Last i will send for server the repository.

@moriel5
Copy link
Contributor Author

moriel5 commented Sep 29, 2020

No problem, should I do this via pull request?

@cantalupo555
Copy link
Owner

No problem, should I do this via pull request?

Yes

@moriel5
Copy link
Contributor Author

moriel5 commented Oct 3, 2020

I'll be on it soon.

@moriel5
Copy link
Contributor Author

moriel5 commented Oct 5, 2020

Taken care of:
#33

@moriel5
Copy link
Contributor Author

moriel5 commented Oct 6, 2020

As mentioned in my newest comment on the pull request, the update needs to wait until the weekly sync on the official Stable Solus repo, due to a dependency (expat) needing to first be updated.

@sarojbelbase
Copy link
Contributor

@moriel5 you can now push changes. It has been updated to the latest and secure one.

@cantalupo555
Copy link
Owner

As mentioned in my newest comment on the pull request, the update needs to wait until the weekly sync on the official Stable Solus repo, due to a dependency (expat) needing to first be updated.

It has been updated.
Is there a dependency problem?

I realized that it sent new packages together, it should have sent separately, so it would be easier to implement on the server.

@cantalupo555 cantalupo555 added the enhancement New feature or request label Oct 17, 2020
@moriel5
Copy link
Contributor Author

moriel5 commented Nov 10, 2020

There was a dependency issue, however it has since been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants