You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
(there was no need to swap rows and cols where the code was vectorized and there are no for loops)
To improve the speed, we should invert rows and columns in each PDE solver. There are many PDEs in this repo, so it is long and hard work. I'm not going to work on this shortly.
In addition to swapping the columns with the rows, we also need to place boundary conditions in different positions inside the matrix.
For instance, for a problem that goes backward in time (such as the BS PDE in notebook 2.1), I used to define the terminal BC in the last column. In the new version, the "terminal BC" should be placed in the last row.
The text was updated successfully, but these errors were encountered:
For loops over rows is faster than over columns.
I have already updated the code in commit 8fe948e, where this code:
was replaced by this:
(there was no need to swap rows and cols where the code was vectorized and there are no for loops)
To improve the speed, we should invert rows and columns in each PDE solver. There are many PDEs in this repo, so it is long and hard work. I'm not going to work on this shortly.
In addition to swapping the columns with the rows, we also need to place boundary conditions in different positions inside the matrix.
For instance, for a problem that goes backward in time (such as the BS PDE in notebook 2.1), I used to define the terminal BC in the last column. In the new version, the "terminal BC" should be placed in the last row.
The text was updated successfully, but these errors were encountered: