Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Log Table: Incorrect Number Format #144

Closed
lyrobnik opened this issue Jan 28, 2025 · 6 comments
Closed

Change Log Table: Incorrect Number Format #144

lyrobnik opened this issue Jan 28, 2025 · 6 comments
Assignees

Comments

@lyrobnik
Copy link

lyrobnik commented Jan 28, 2025

Hello Team,

We have noticed an issue on the Change log table: sometimes numbers are rendered in an incorrect format.

Image

Is this a known issue and could you please provide any help to fix this?

Thanks & Regards,
Lydia

@lyrobnik
Copy link
Author

In this example the number 8,000 (old value) was changed to 500 (new value):

Image

@jonasdutzisap
Copy link

Hi @nkaputnik,

could you please give an update?
Are you aware of the issue and maybe already working on it? :)

Best regards,
Jonas

@nkaputnik
Copy link
Contributor

Hello @jonasdutzisap could you perhaps create a small reproducible example for us to debug it?

Best,
Nick

@lyrobnik
Copy link
Author

Hi @nkaputnik, like discussed I provided you access to our system to reproduce the issue.

CC @jonasdutzisap

@Sv7enNowitzki
Copy link
Collaborator

Hi @lyrobnik ,

Providing this only for the online environment may not be ideal, as we might need to understand some of the related code on how this result is produced in order to reproduce and attempt to resolve it. Could you please provide some relevant examples for us?

In addition, please also grant me partial access.

Best Regards,
Wenjun

@Sv7enNowitzki
Copy link
Collaborator

Sv7enNowitzki commented Mar 26, 2025

Hello @lyrobnik ,

Based on my analysis, I found that this issue is caused by the use of the hdb driver. It appears that when using hdb or hana-client in the project, such problems occur with Decimal fields. Starting from CDS8, CAP strongly recommends replacing these two drivers with cap-js/hana. You can refer to the specifics here.

Similar issue has also been mentioned in the CAP issues:
https://github.tools.sap/cap/issues/issues/15074

If you use the new driver, your issue won't arise anymore. Therefore, for change tracking, no fixes are currently needed.

Therefore, I suggest testing this issue again when you upgrade to CDS 8 and set cap-js/hana as the new driver. If the issue still persists, please contact us again.

Image

Best Regards,
Wenjun

@Sv7enNowitzki Sv7enNowitzki added author action Need the actions taken by an author and removed author action Need the actions taken by an author labels Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants